Heikki Levanto [Fri, 7 Mar 2014 12:43:57 +0000 (13:43 +0100)]
Do note test return value of .trigger("click")
It should return this, but seems that some times it does not.
Anyway, that test is not really testing our things. The
subsequent tests on content and visibility should catch a missed
click anyway.
Heikki Levanto [Fri, 7 Mar 2014 12:40:03 +0000 (13:40 +0100)]
Do not test the return value of .trigger("click")
The tirgger() is supposed to return this, but seems not to do
so always. The subsequent tests confirm that the click event
has happened anyway.
If the click event does not happen for some reason, the next
tests will fail, so I believe the testing is as good.
Heikki Levanto [Fri, 7 Mar 2014 12:39:28 +0000 (13:39 +0100)]
More about setting up apache
needed to do this to work on my home machine, so I documented
what was needed.
Wolfram Schneider [Fri, 7 Mar 2014 10:25:49 +0000 (10:25 +0000)]
add a prefix for jasmine console log messages
Wolfram Schneider [Fri, 7 Mar 2014 10:15:35 +0000 (10:15 +0000)]
Unit tests for the MOTD MKWS-134
Heikki Levanto [Thu, 6 Mar 2014 14:43:25 +0000 (15:43 +0100)]
Unit tests for the MOTD MKWS-134
Added tests for the MOTD being moved to the right place before search
and not being visible after search. Temporarily broke the code to
verify my tests.
Heikki Levanto [Wed, 5 Mar 2014 14:35:21 +0000 (15:35 +0100)]
Minor comment about environment
Mike Taylor [Wed, 5 Mar 2014 10:04:16 +0000 (10:04 +0000)]
Automatic termlist widgets now work:
<div id='mkwsTermlists' autosearch='dinosaur' sort='relevance'></div>
Mike Taylor [Wed, 5 Mar 2014 09:57:09 +0000 (09:57 +0000)]
Mike's playground reverted to an auto-widget.
Mike Taylor [Wed, 5 Mar 2014 09:54:45 +0000 (09:54 +0000)]
Remove redundant utility function mkws.parseQuerystring().
Use mkws.getParameterByName() instead.
Mike Taylor [Wed, 5 Mar 2014 09:46:25 +0000 (09:46 +0000)]
Rewrite comment.
Mike Taylor [Wed, 5 Mar 2014 09:45:03 +0000 (09:45 +0000)]
Move URL-parsing utility functions out of the team.
Mike Taylor [Wed, 5 Mar 2014 09:33:38 +0000 (09:33 +0000)]
Move mkws.defaultTemplate() out of the team structure.
Fixes part of MKWS-126.
Mike Taylor [Wed, 5 Mar 2014 09:25:16 +0000 (09:25 +0000)]
Fix whitespace.
Mike Taylor [Wed, 5 Mar 2014 09:24:33 +0000 (09:24 +0000)]
Remove ALL ID-based targets from CSS.
Fixes the last part of MWKS-117.
Mike Taylor [Wed, 5 Mar 2014 09:19:41 +0000 (09:19 +0000)]
Set full-record HTML using jQuery rather than innerHTML.
Fixes the last part of MKWS-22.
Mike Taylor [Tue, 4 Mar 2014 17:21:23 +0000 (17:21 +0000)]
Change Mike's playground to two-team version.
Mike Taylor [Tue, 4 Mar 2014 17:13:23 +0000 (17:13 +0000)]
Comment.
Mike Taylor [Tue, 4 Mar 2014 17:11:19 +0000 (17:11 +0000)]
Move event-queue code into teams.
Events are now subscribed/published on team-specific basis.
As a result, we don't need the ugly faceted event names.
Mike Taylor [Tue, 4 Mar 2014 16:48:16 +0000 (16:48 +0000)]
stat event-queueing is per-team.
Mike Taylor [Tue, 4 Mar 2014 15:24:31 +0000 (15:24 +0000)]
New team member-function, name().
"targets" events are now registered per-team.
Mike Taylor [Tue, 4 Mar 2014 15:04:36 +0000 (15:04 +0000)]
Move "return" higher up widget factory method.
Local functions come after it.
Mike Taylor [Tue, 4 Mar 2014 15:03:48 +0000 (15:03 +0000)]
Remove no-longer pertinent comment.
Mike Taylor [Tue, 4 Mar 2014 14:56:10 +0000 (14:56 +0000)]
Remove unused teamName arguments from several pz2 callbacks.
Mike Taylor [Tue, 4 Mar 2014 14:54:54 +0000 (14:54 +0000)]
Status line implemented using pub/sub
Mike Taylor [Tue, 4 Mar 2014 14:49:07 +0000 (14:49 +0000)]
Tighten up.
Mike Taylor [Tue, 4 Mar 2014 14:10:50 +0000 (14:10 +0000)]
Fix CSS for targets area.
(HTML is assigned to a subnode, not the widget node itself.)
Mike Taylor [Tue, 4 Mar 2014 14:07:47 +0000 (14:07 +0000)]
Targets list is now generated by widget, not team.
This is done using publish/subscribe -- yay!
For some reason, the CSS styles are not getting applied.
Mike Taylor [Tue, 4 Mar 2014 13:05:12 +0000 (13:05 +0000)]
Last (for now!) re-ordering.
The whole sequence makes a lot more sense now.
Mike Taylor [Tue, 4 Mar 2014 13:02:02 +0000 (13:02 +0000)]
More reordering.
Mike Taylor [Tue, 4 Mar 2014 13:01:09 +0000 (13:01 +0000)]
More reordering.
Mike Taylor [Tue, 4 Mar 2014 12:53:07 +0000 (12:53 +0000)]
More re-ordered to draw related code together.
Mike Taylor [Tue, 4 Mar 2014 12:51:02 +0000 (12:51 +0000)]
Remove redundantly verbose logging.
Mike Taylor [Tue, 4 Mar 2014 12:42:42 +0000 (12:42 +0000)]
More consistency.
Mike Taylor [Tue, 4 Mar 2014 12:33:24 +0000 (12:33 +0000)]
Rename variable for consistency.
Mike Taylor [Tue, 4 Mar 2014 12:32:36 +0000 (12:32 +0000)]
Fix code that skips filling in onTarget area.
Mike Taylor [Tue, 4 Mar 2014 12:31:18 +0000 (12:31 +0000)]
Simplify configuration and make more consistent.
Mike Taylor [Tue, 4 Mar 2014 12:20:47 +0000 (12:20 +0000)]
Move more global code (protocol-independent link adjusting) out of the team.
Mike Taylor [Mon, 3 Mar 2014 17:36:32 +0000 (17:36 +0000)]
Move all template code to end of team objects.
Mike Taylor [Mon, 3 Mar 2014 17:22:28 +0000 (17:22 +0000)]
Move related utility functions together.
Mike Taylor [Mon, 3 Mar 2014 17:18:17 +0000 (17:18 +0000)]
Move utility function findnode() to near the end.
Mike Taylor [Mon, 3 Mar 2014 17:10:26 +0000 (17:10 +0000)]
Reorder functions: all onXXX handlers together, in order.
Mike Taylor [Mon, 3 Mar 2014 16:57:57 +0000 (16:57 +0000)]
Remove pointless "showResponseType" pz2 constructor param.
Mike Taylor [Mon, 3 Mar 2014 16:55:55 +0000 (16:55 +0000)]
Re-order parameters to pz2 constructor.
Mike Taylor [Mon, 3 Mar 2014 16:35:35 +0000 (16:35 +0000)]
Reorder some code.
Mike Taylor [Mon, 3 Mar 2014 16:30:41 +0000 (16:30 +0000)]
ALL function names changed from embedded_underscore to camelCase.
For example, add_single_facet -> addSingleFacet
Mike Taylor [Mon, 3 Mar 2014 16:15:51 +0000 (16:15 +0000)]
Rename all my_onoperation functions to onOperation.
Mike Taylor [Mon, 3 Mar 2014 16:01:28 +0000 (16:01 +0000)]
Remove outdated comment.
Mike Taylor [Mon, 3 Mar 2014 16:00:27 +0000 (16:00 +0000)]
Move resize-setup code.
Mike Taylor [Mon, 3 Mar 2014 15:59:16 +0000 (15:59 +0000)]
Simplify
Mike Taylor [Mon, 3 Mar 2014 15:41:14 +0000 (15:41 +0000)]
Remove extraneous default-valued config elements.
Mike Taylor [Mon, 3 Mar 2014 15:20:03 +0000 (15:20 +0000)]
Fix comment.
Mike Taylor [Mon, 3 Mar 2014 15:19:54 +0000 (15:19 +0000)]
Remove explicit windowid parameter from newSearch() and triggerSearch()
This is not needed, as the team-name is passed into the pz2 constructor.
Mike Taylor [Mon, 3 Mar 2014 14:38:30 +0000 (14:38 +0000)]
Remove obsolete comment.
Mike Taylor [Mon, 3 Mar 2014 14:37:30 +0000 (14:37 +0000)]
Dramatically simplify onFormSubmitEventHandler()
newSearch() can now be a regular, hidden member function.
Mike Taylor [Mon, 3 Mar 2014 13:44:40 +0000 (13:44 +0000)]
Merge branch 'master' of ssh://git.indexdata.com/home/git/private/mkws
Mike Taylor [Mon, 3 Mar 2014 13:44:30 +0000 (13:44 +0000)]
Move some global code down out of the team object.
Wolfram Schneider [Mon, 3 Mar 2014 13:38:18 +0000 (13:38 +0000)]
add jasmine test account
Wolfram Schneider [Mon, 3 Mar 2014 13:36:24 +0000 (13:36 +0000)]
use jasmine test account
Wolfram Schneider [Mon, 3 Mar 2014 23:34:58 +0000 (23:34 +0000)]
add jasmine test account
Wolfram Schneider [Mon, 3 Mar 2014 13:32:01 +0000 (13:32 +0000)]
add rewrite rules for jasmine test account, MKWS-132
Wolfram Schneider [Mon, 3 Mar 2014 13:31:33 +0000 (13:31 +0000)]
setup to use local SP with MKWS jasmine test account, MKWS-13
Wolfram Schneider [Mon, 3 Mar 2014 13:28:47 +0000 (13:28 +0000)]
setup to use local SP with MKWS jasmine test account, MKWS-132
Mike Taylor [Fri, 28 Feb 2014 16:32:36 +0000 (16:32 +0000)]
Merge branch 'master' of ssh://git.indexdata.com/home/git/private/mkws
Mike Taylor [Fri, 28 Feb 2014 16:32:28 +0000 (16:32 +0000)]
Copy of mobile.html
Mike Taylor [Fri, 28 Feb 2014 16:23:42 +0000 (16:23 +0000)]
Fix a couple of escaped selectors to use findnode()
Mike Taylor [Fri, 28 Feb 2014 16:21:12 +0000 (16:21 +0000)]
findnode() correctly handles selectors with commas ("or").
It is now used in the case where we have such a thing.
Mike Taylor [Fri, 28 Feb 2014 15:47:24 +0000 (15:47 +0000)]
Fix findnode() logic for allowing default team-name to be overridden.
Mike Taylor [Fri, 28 Feb 2014 15:45:29 +0000 (15:45 +0000)]
Stupid JS doesn't have the ||= operator.
Mike Taylor [Fri, 28 Feb 2014 15:45:17 +0000 (15:45 +0000)]
Lolcat demo
Mike Taylor [Fri, 28 Feb 2014 15:43:51 +0000 (15:43 +0000)]
Use findnode() for backup template name.
Mike Taylor [Fri, 28 Feb 2014 15:42:49 +0000 (15:42 +0000)]
findnode() takes optional second argument teamName
Mike Taylor [Fri, 28 Feb 2014 15:42:23 +0000 (15:42 +0000)]
Rename variable.
Mike Taylor [Fri, 28 Feb 2014 15:39:47 +0000 (15:39 +0000)]
Add utility method findnode(), limited to elements in present team.
Use this in 25 places.
Mike Taylor [Fri, 28 Feb 2014 15:28:05 +0000 (15:28 +0000)]
Add nine ###-comments arising from code-read with Heikki.
Heikki Levanto [Fri, 28 Feb 2014 14:52:43 +0000 (15:52 +0100)]
Some typos
Heikki Levanto [Fri, 28 Feb 2014 14:25:25 +0000 (15:25 +0100)]
Mike's comments on mkws.js
Heikki Levanto [Fri, 28 Feb 2014 13:23:43 +0000 (14:23 +0100)]
Collect useful advice for developers into one file
Heikki Levanto [Fri, 28 Feb 2014 12:50:19 +0000 (13:50 +0100)]
Merge branch 'master' of ssh://git.indexdata.com:222/home/git/private/mkws
Heikki Levanto [Fri, 28 Feb 2014 12:49:48 +0000 (13:49 +0100)]
Add MOTD to teh div id to class conversion list MKWS-133
Mike Taylor [Fri, 28 Feb 2014 12:45:56 +0000 (12:45 +0000)]
Merge branch 'master' of ssh://git.indexdata.com/home/git/private/mkws
Mike Taylor [Fri, 28 Feb 2014 12:45:52 +0000 (12:45 +0000)]
Two teams.
Mike Taylor [Fri, 28 Feb 2014 12:45:19 +0000 (12:45 +0000)]
Hugely simplify setting up the on-submit actions for search forms.
Mike Taylor [Fri, 28 Feb 2014 12:33:28 +0000 (12:33 +0000)]
Further simplify to eliminate temporary variable `node'
Mike Taylor [Fri, 28 Feb 2014 12:32:33 +0000 (12:32 +0000)]
FINALLY simplify the unnecessary iteration over all one of the search
forms of a given team.
Mike Taylor [Fri, 28 Feb 2014 12:31:10 +0000 (12:31 +0000)]
mkws.handle_node_with_team() now works with both DOM nodes and jQuery
objects.
Previously it handled only the former. For some retarded reason
related to the JavaScript runtime, if it was given the latter (so that
node.className was undefined), pushing on and assigning
list = classes.split(/\s+/)
would not yield an error message: instead, this function and its
callers, up several stack level, silently return. What a crock.
This took FOREVER to find.
Heikki Levanto [Fri, 28 Feb 2014 11:33:38 +0000 (12:33 +0100)]
Add a test page for the motd problem FRES-4
Mike Taylor [Fri, 28 Feb 2014 11:20:52 +0000 (11:20 +0000)]
Back to simple sandbox.
Mike Taylor [Fri, 28 Feb 2014 11:04:01 +0000 (11:04 +0000)]
handle_node_with_team() sets `this' to the node in the callback.
Mike Taylor [Fri, 28 Feb 2014 10:31:26 +0000 (10:31 +0000)]
Rename variable.
Mike Taylor [Fri, 28 Feb 2014 10:30:50 +0000 (10:30 +0000)]
handle_node_with_team() now passes widget-type as well as class to callback.
widget() factory method accepts `type' argument.
widget() factory method logs object creation.
Mike Taylor [Thu, 27 Feb 2014 16:05:37 +0000 (16:05 +0000)]
Use `this' instead of temporary.
Mike Taylor [Thu, 27 Feb 2014 16:04:33 +0000 (16:04 +0000)]
Use `this' instead of temporary.
Mike Taylor [Thu, 27 Feb 2014 16:02:34 +0000 (16:02 +0000)]
Fix handle_node_with_team() to correctly set `this' within callback.
Heikki Levanto [Thu, 27 Feb 2014 15:27:29 +0000 (16:27 +0100)]
Merge branch 'master' of ssh://git.indexdata.com:222/home/git/private/mkws
Heikki Levanto [Thu, 27 Feb 2014 15:27:14 +0000 (16:27 +0100)]
My tests, setup stuff
Mike Taylor [Thu, 27 Feb 2014 15:27:07 +0000 (15:27 +0000)]
Obsoleted by bug MKWS-130
Mike Taylor [Thu, 27 Feb 2014 15:23:56 +0000 (15:23 +0000)]
Add simple PubSub code adapted from jQuery manual.
Mike Taylor [Thu, 27 Feb 2014 15:10:23 +0000 (15:10 +0000)]
Merge branch 'master' of ssh://git.indexdata.com/home/git/private/mkws
Wolfram Schneider [Thu, 27 Feb 2014 15:04:38 +0000 (15:04 +0000)]
fetch pz2.js from git.indexdata.com as we do for jquery libs. MKWS-131