X-Git-Url: http://lists.indexdata.dk/cgi-bin?a=blobdiff_plain;f=src%2Fmain%2Fjava%2Fcom%2Findexdata%2Fmkjsf%2Fpazpar2%2FPz2Client.java;h=fc919f3a7f3d2002475a973ae7c05bac02cee3cd;hb=5584e83f4b8d6c66999048dafcb9ce6999808894;hp=78627d996a7131fe3926039f0614a8f6beffdffe;hpb=290b089e0e807f4d54c13eb0b309fe41ff78d89b;p=mkjsf-moved-to-github.git diff --git a/src/main/java/com/indexdata/mkjsf/pazpar2/Pz2Client.java b/src/main/java/com/indexdata/mkjsf/pazpar2/Pz2Client.java index 78627d9..fc919f3 100644 --- a/src/main/java/com/indexdata/mkjsf/pazpar2/Pz2Client.java +++ b/src/main/java/com/indexdata/mkjsf/pazpar2/Pz2Client.java @@ -24,6 +24,7 @@ import com.indexdata.mkjsf.config.Configuration; import com.indexdata.mkjsf.config.ConfigurationReader; import com.indexdata.mkjsf.errors.ConfigurationException; import com.indexdata.mkjsf.pazpar2.commands.Pazpar2Command; +import com.indexdata.mkjsf.pazpar2.data.CommandError; import com.indexdata.mkjsf.utils.Utils; public class Pz2Client implements SearchClient { @@ -34,9 +35,10 @@ public class Pz2Client implements SearchClient { private Pazpar2ClientConfiguration cfg = null; public static final String MODULENAME = "pz2client"; public static Map DEFAULTS = new HashMap(); - Configuration config = null; + Configuration config = null; static { + DEFAULTS.put("PAZPAR2_URL", ""); DEFAULTS.put("PROXY_MODE","1"); DEFAULTS.put("SERIALIZE_REQUESTS", "false"); DEFAULTS.put("STREAMBUFF_SIZE", "4096"); @@ -49,7 +51,7 @@ public class Pz2Client implements SearchClient { public void configure(ConfigurationReader configReader) throws ConfigurationException { logger.info(Utils.objectId(this) + " is configuring using the provided " + Utils.objectId(configReader)); try { - config = configReader.getConfiguration(this); + config = configReader.getConfiguration(this); cfg = new Pazpar2ClientConfiguration(new ConfigurationGetter(config)); } catch (ProxyErrorException pe) { logger.error("Could not configure Pazpar2 client: " + pe.getMessage()); @@ -82,16 +84,43 @@ public class Pz2Client implements SearchClient { @Override public void setSearchCommand(Pazpar2Command command) { - ClientCommand clientCommand = new ClientCommand(command.getName(), command.getEncodedQueryString()); + ClientCommand clientCommand = new ClientCommand(command.getCommandName(), command.getEncodedQueryString()); client.setSearchCommand(clientCommand); } @Override - public CommandResponse executeCommand(Pazpar2Command command, ByteArrayOutputStream baos) - throws Pazpar2ErrorException, IOException { - ClientCommand clientCommand = new ClientCommand(command.getName(), command.getEncodedQueryString()); - Pazpar2HttpResponse pz2HttpResponse = client.executeCommand(clientCommand, baos); - return new Pz2CommandResponse(pz2HttpResponse,baos); + public HttpResponseWrapper executeCommand(Pazpar2Command command) { + ClientCommandResponse commandResponse = null; + ByteArrayOutputStream baos = new ByteArrayOutputStream(); + ClientCommand clientCommand = new ClientCommand(command.getCommandName(), command.getEncodedQueryString()); + Pazpar2HttpResponse pz2HttpResponse = null; + long start = System.currentTimeMillis(); + try { + pz2HttpResponse = client.executeCommand(clientCommand, baos); + if (pz2HttpResponse.getStatusCode()==200) { + commandResponse = new ClientCommandResponse(pz2HttpResponse,baos); + } else if (pz2HttpResponse.getStatusCode()==417) { + logger.error("Pazpar2 status code 417: " + baos.toString("UTF-8")); + commandResponse = new ClientCommandResponse(pz2HttpResponse.getStatusCode(),CommandError.insertErrorXml(command.getCommandName(), String.valueOf(pz2HttpResponse.getStatusCode()) ,"Pazpar2: Expectation failed (417)", baos.toString("UTF-8")),"text/xml"); + } else { + String resp = baos.toString("UTF-8"); + logger.error("Pazpar2 status code was " + pz2HttpResponse.getStatusCode() + ": " + resp); + commandResponse = new ClientCommandResponse(pz2HttpResponse.getStatusCode(),CommandError.insertErrorXml(command.getCommandName(), String.valueOf(pz2HttpResponse.getStatusCode()), "Pazpar2 error occurred", baos.toString("UTF-8")),"text/xml"); + throw new Pazpar2ErrorException(resp,pz2HttpResponse.getStatusCode(),resp,null); + } + } catch (IOException e) { + logger.error(e.getMessage()); + e.printStackTrace(); + commandResponse = new ClientCommandResponse(-1,CommandError.createErrorXml(command.getCommandName(), String.valueOf(pz2HttpResponse.getStatusCode()), "io", e.getMessage()),"text/xml"); + } catch (Pazpar2ErrorException e) { + logger.error(e.getMessage()); + e.printStackTrace(); + logger.error("Creating error XML"); + commandResponse = new ClientCommandResponse(-1,CommandError.createErrorXml(command.getCommandName(), String.valueOf(pz2HttpResponse.getStatusCode()), "io", e.getMessage()),"text/xml"); + } + long end = System.currentTimeMillis(); + logger.debug("Executed " + command.getCommandName() + " in " + (end-start) + " ms." ); + return commandResponse; } public Pz2Client cloneMe() { @@ -147,4 +176,20 @@ public class Pz2Client implements SearchClient { return config; } + @Override + public String getServiceUrl() { + return cfg.PAZPAR2_URL; + } + + @Override + public boolean hasServiceUrl() { + return cfg.PAZPAR2_URL != null && cfg.PAZPAR2_URL.length()>0; + } + + @Override + public void setServiceUrl (String serviceUrl) { + cfg.PAZPAR2_URL = serviceUrl; + + } + }