X-Git-Url: http://lists.indexdata.dk/cgi-bin?a=blobdiff_plain;f=src%2Fhttp_command.c;h=8887e91e3dc2323561dc582ed604590cfac559a7;hb=51616c6be3de7b3818379384e2e23600fd4e01c8;hp=17521311c92d14f0269dfa08c8b2ea641df05aa5;hpb=fa325dc3607ed67eeea472f90a67ca35b6739c30;p=pazpar2-moved-to-github.git
diff --git a/src/http_command.c b/src/http_command.c
index 1752131..8887e91 100644
--- a/src/http_command.c
+++ b/src/http_command.c
@@ -1,5 +1,5 @@
/* This file is part of Pazpar2.
- Copyright (C) 2006-2011 Index Data
+ Copyright (C) 2006-2012 Index Data
Pazpar2 is free software; you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free
@@ -49,16 +49,16 @@ void print_meminfo(WRBUF wrbuf)
struct mallinfo minfo;
minfo = mallinfo();
wrbuf_printf(wrbuf, " \n"
- " %d\n"
+ " %d\n"
" %d\n"
" %d\n"
" %d\n"
" %d\n"
- " %d\n"
+ " %d\n"
" %d\n"
" %d\n"
" %d\n"
- " \n",
+ " \n",
minfo.arena, minfo.uordblks, minfo.fordblks,minfo.ordblks, minfo.keepcost, minfo.hblks, minfo.hblkhd, minfo.arena + minfo.hblkhd, minfo.uordblks + minfo.hblkhd);
}
@@ -93,6 +93,16 @@ struct http_sessions {
static YAZ_MUTEX g_http_session_mutex = 0;
static int g_http_sessions = 0;
+int get_version(struct http_request *rq) {
+ const char *version = http_argbyname(rq, "version");
+ int version_no = 0;
+ if (version && strcmp(version, "")) {
+ version_no = atoi(version);
+ }
+ return version_no;
+}
+
+
int http_session_use(int delta)
{
int sessions;
@@ -204,7 +214,7 @@ void http_session_destroy(struct http_session *s)
nmem_destroy(s->nmem);
}
else {
- yaz_log(http_sessions->log_level, "Session %u destroyed delayed. Active clients (%d-%d). Waiting for new timeout.",
+ yaz_log(http_sessions->log_level, "Session %u destroying delayed. Active clients (%d-%d). Waiting for new timeout.",
s->session_id, s->activity_counter, s->destroy_counter);
}
@@ -243,7 +253,7 @@ static const char *get_msg(enum pazpar2_error_code code)
return "No error";
}
-static void error(struct http_response *rs,
+static void error(struct http_response *rs,
enum pazpar2_error_code code,
const char *addinfo)
{
@@ -251,7 +261,7 @@ static void error(struct http_response *rs,
WRBUF text = wrbuf_alloc();
const char *http_status = "417";
const char *msg = get_msg(code);
-
+
rs->msg = nmem_strdup(c->nmem, msg);
strcpy(rs->code, http_status);
@@ -310,7 +320,7 @@ unsigned int make_sessionid(void)
yaz_log(YLOG_WARN|YLOG_ERRNO, "gettimeofday");
exit(1);
}
- /* at most 256 sessions per second ..
+ /* at most 256 sessions per second ..
(long long would be more appropriate)*/
res = t.tv_sec;
res = ((res << 8) | (seq & 0xff)) & ((1U << 31) - 1);
@@ -407,8 +417,8 @@ static void cmd_init(struct http_channel *c)
struct http_session *s;
struct http_response *rs = c->response;
struct conf_service *service = 0; /* no service (yet) */
-
- if (r->content_len && content_type &&
+
+ if (r->content_len && content_type &&
!yaz_strcmp_del("text/xml", content_type, "; "))
{
xmlDoc *doc = xmlParseMemory(r->content_buf, r->content_len);
@@ -427,7 +437,7 @@ static void cmd_init(struct http_channel *c)
return;
}
}
-
+
if (!service)
{
const char *service_name = http_argbyname(c->request, "service");
@@ -440,13 +450,13 @@ static void cmd_init(struct http_channel *c)
}
sesid = make_sessionid();
s = http_session_create(service, c->http_sessions, sesid);
-
+
yaz_log(c->http_sessions->log_level, "Session init %u ", sesid);
if (!clear || *clear == '0')
session_init_databases(s->psession);
else
yaz_log(YLOG_LOG, "Session %u init: No databases preloaded", sesid);
-
+
if (process_settings(s->psession, c->request, c->response) < 0)
return;
@@ -459,7 +469,9 @@ static void cmd_init(struct http_channel *c)
}
wrbuf_puts(c->wrbuf, ""
"" PAZPAR2_PROTOCOL_VERSION "");
-
+
+ wrbuf_printf(c->wrbuf, "%d\n", 1000 * ((s->psession->service->session_timeout >= 20) ?
+ (s->psession->service->session_timeout - 10) : 50));
response_close(c, "init");
}
@@ -483,11 +495,12 @@ static void cmd_settings(struct http_channel *c)
if (!s)
return;
- if (rq->content_len && content_type &&
+ if (rq->content_len && content_type &&
!yaz_strcmp_del("text/xml", content_type, "; "))
{
xmlDoc *doc = xmlParseMemory(rq->content_buf, rq->content_len);
xmlNode *root_n;
+ int ret;
if (!doc)
{
error(rs, PAZPAR2_MALFORMED_SETTING, 0);
@@ -495,10 +508,14 @@ static void cmd_settings(struct http_channel *c)
return;
}
root_n = xmlDocGetRootElement(doc);
-
- settings_read_node_x(root_n, s->psession, apply_local_setting);
-
+ ret = settings_read_node_x(root_n, s->psession, apply_local_setting);
xmlFreeDoc(doc);
+ if (ret)
+ {
+ error(rs, PAZPAR2_MALFORMED_SETTING, 0);
+ release_session(c,s);
+ return;
+ }
}
if (process_settings(s->psession, rq, rs) < 0)
{
@@ -510,11 +527,12 @@ static void cmd_settings(struct http_channel *c)
release_session(c, s);
}
-static void termlist_response(struct http_channel *c, struct http_session *s)
+static void termlist_response(struct http_channel *c, struct http_session *s, const char *cmd_status)
{
struct http_request *rq = c->request;
- const char *name = http_argbyname(rq, "name");
- const char *nums = http_argbyname(rq, "num");
+ const char *name = http_argbyname(rq, "name");
+ const char *nums = http_argbyname(rq, "num");
+ int version = get_version(rq);
int num = 15;
int status;
@@ -524,9 +542,13 @@ static void termlist_response(struct http_channel *c, struct http_session *s)
status = session_active_clients(s->psession);
response_open_no_status(c, "termlist");
+ /* new protocol add a status to response. Triggered by a status parameter */
+ if (cmd_status != 0) {
+ wrbuf_printf(c->wrbuf, "%s\n", cmd_status);
+ }
wrbuf_printf(c->wrbuf, "%d\n", status);
- perform_termlist(c, s->psession, name, num);
+ perform_termlist(c, s->psession, name, num, version);
response_close(c, "termlist");
}
@@ -534,10 +556,15 @@ static void termlist_response(struct http_channel *c, struct http_session *s)
static void termlist_result_ready(void *data)
{
struct http_channel *c = (struct http_channel *) data;
+ struct http_request *rq = c->request;
+ const char *report = http_argbyname(rq, "report");
+ const char *status = 0;
struct http_session *s = locate_session(c);
+ if (report && !strcmp("status", report))
+ status = "OK";
if (s) {
yaz_log(c->http_sessions->log_level, "Session %u termlist watch released", s->session_id);
- termlist_response(c, s);
+ termlist_response(c, s, status);
release_session(c,s);
}
}
@@ -548,12 +575,23 @@ static void cmd_termlist(struct http_channel *c)
struct http_response *rs = c->response;
struct http_session *s = locate_session(c);
const char *block = http_argbyname(rq, "block");
+ const char *report = http_argbyname(rq, "report");
+ int report_status = 0;
+ int report_error = 0;
+ const char *status_message = 0;
int active_clients;
+ if (report && !strcmp("error", report)) {
+ report_error = 1;
+ status_message = "OK";
+ }
+ if (report && !strcmp("status", report)) {
+ report_status = 1;
+ status_message = "OK";
+ }
if (!s)
return;
active_clients = session_active_clients(s->psession);
-
if (block && !strcmp("1", block) && active_clients)
{
// if there is already a watch/block. we do not block this one
@@ -561,17 +599,27 @@ static void cmd_termlist(struct http_channel *c)
termlist_result_ready, c, c) != 0)
{
yaz_log(YLOG_WARN, "Session %u: Attempt to block multiple times on termlist block. Not supported!", s->session_id);
- error(rs, PAZPAR2_ALREADY_BLOCKED, "termlist");
+ if (report_error) {
+ error(rs, PAZPAR2_ALREADY_BLOCKED, "termlist");
+ release_session(c, s);
+ return;
+ }
+ else if (report_status) {
+ status_message = "WARNING (Already blocked on termlist)";
+ }
+ else {
+ yaz_log(YLOG_WARN, "Session %u: Ignoring termlist block. Return current result", s->session_id);
+ }
}
else
{
yaz_log(c->http_sessions->log_level, "Session %u: Blocking on command termlist", s->session_id);
+ release_session(c, s);
+ return;
}
- release_session(c, s);
- return;
}
- termlist_response(c, s);
+ termlist_response(c, s, status_message);
release_session(c, s);
}
@@ -641,14 +689,22 @@ static void cmd_server_status(struct http_channel *c)
xmalloc_trav(0);
}
-static void bytarget_response(struct http_channel *c, struct http_session *s) {
+static void bytarget_response(struct http_channel *c, struct http_session *s, const char *cmd_status) {
int count, i;
struct hitsbytarget *ht;
struct http_request *rq = c->request;
const char *settings = http_argbyname(rq, "settings");
-
+ int version = get_version(rq);
ht = get_hitsbytarget(s->psession, &count, c->nmem);
- response_open(c, "bytarget");
+ if (!cmd_status)
+ /* Old protocol, always ok */
+ response_open(c, "bytarget");
+ else {
+ /* New protocol, OK or WARNING (...)*/
+ response_open_no_status(c, "bytarget");
+ wrbuf_printf(c->wrbuf, "%s", cmd_status);
+ }
+
if (count == 0)
yaz_log(YLOG_WARN, "Empty bytarget Response. No targets found!");
for (i = 0; i < count; i++)
@@ -659,7 +715,7 @@ static void bytarget_response(struct http_channel *c, struct http_session *s) {
wrbuf_xmlputs(c->wrbuf, ht[i].id);
wrbuf_puts(c->wrbuf, "\n");
- if (ht[i].name && ht[i].name[0])
+ if (ht[i].name && ht[i].name[0])
{
wrbuf_puts(c->wrbuf, "");
wrbuf_xmlputs(c->wrbuf, ht[i].name);
@@ -676,8 +732,11 @@ static void bytarget_response(struct http_channel *c, struct http_session *s) {
wrbuf_puts(c->wrbuf, "\n");
}
- wrbuf_printf(c->wrbuf, "%d\n", ht[i].records);
-
+ wrbuf_printf(c->wrbuf, "%d\n", ht[i].records - ht[i].filtered);
+ if (version >= 2) {
+ wrbuf_printf(c->wrbuf, "%d\n", ht[i].filtered);
+ wrbuf_printf(c->wrbuf, "" ODR_INT_PRINTF "\n", ht[i].approximation);
+ }
wrbuf_puts(c->wrbuf, "");
wrbuf_xmlputs(c->wrbuf, ht[i].state);
wrbuf_puts(c->wrbuf, "\n");
@@ -701,9 +760,10 @@ static void bytarget_result_ready(void *data)
{
struct http_channel *c = (struct http_channel *) data;
struct http_session *s = locate_session(c);
+ const char *status_message = "OK";
if (s) {
yaz_log(c->http_sessions->log_level, "Session %u: bytarget watch released", s->session_id);
- bytarget_response(c, s);
+ bytarget_response(c, s, status_message);
release_session(c, s);
}
else {
@@ -718,13 +778,23 @@ static void cmd_bytarget(struct http_channel *c)
struct http_response *rs = c->response;
struct http_session *s = locate_session(c);
const char *block = http_argbyname(rq, "block");
+ const char *report = http_argbyname(rq, "report");
+ int report_error = 0;
+ int report_status = 0;
+ const char *status_message = "OK";
int no_active;
+ if (report && !strcmp("error", report)) {
+ report_error = 1;
+ }
+ if (report && !strcmp("status", report)) {
+ report_status = 1;
+ }
+
if (!s)
return;
no_active = session_active_clients(s->psession);
-
if (block && !strcmp("1",block) && no_active)
{
// if there is already a watch/block. we do not block this one
@@ -732,21 +802,31 @@ static void cmd_bytarget(struct http_channel *c)
bytarget_result_ready, c, c) != 0)
{
yaz_log(YLOG_WARN, "Session %u: Attempt to block multiple times on bytarget block. Not supported!", s->session_id);
- error(rs, PAZPAR2_ALREADY_BLOCKED, "bytarget");
+ if (report_error) {
+ error(rs, PAZPAR2_ALREADY_BLOCKED, "bytarget");
+ release_session(c, s);
+ return;
+ }
+ else if (report_status) {
+ status_message = "WARNING (Already blocked on bytarget)";
+ }
+ else {
+ yaz_log(YLOG_WARN, "Session %u: Ignoring bytarget block. Return current result.", s->session_id);
+ }
}
else
{
yaz_log(c->http_sessions->log_level, "Session %u: Blocking on command bytarget", s->session_id);
+ release_session(c, s);
+ return;
}
- release_session(c, s);
- return;
}
- bytarget_response(c, s);
+ bytarget_response(c, s, status_message);
release_session(c, s);
}
static void write_metadata(WRBUF w, struct conf_service *service,
- struct record_metadata **ml, int full)
+ struct record_metadata **ml, int full, int indent)
{
int imeta;
@@ -759,7 +839,10 @@ static void write_metadata(WRBUF w, struct conf_service *service,
for (md = ml[imeta]; md; md = md->next)
{
struct record_metadata_attr *attr = md->attributes;
- wrbuf_printf(w, "\nname);
+ int i;
+ for (i = 0; i < indent; i++)
+ wrbuf_putc(w, ' ');
+ wrbuf_printf(w, "name);
for (; attr; attr = attr->next)
{
@@ -782,7 +865,7 @@ static void write_metadata(WRBUF w, struct conf_service *service,
wrbuf_puts(w, "[can't represent]");
break;
}
- wrbuf_printf(w, "", cmd->name);
+ wrbuf_printf(w, "\n", cmd->name);
}
}
}
@@ -793,16 +876,20 @@ static void write_subrecord(struct record *r, WRBUF w,
const char *name = session_setting_oneval(
client_get_database(r->client), PZ_NAME);
- wrbuf_puts(w, "client));
- wrbuf_puts(w, "\" ");
+ wrbuf_puts(w, "\"\n");
- wrbuf_puts(w, "name=\"");
+ wrbuf_puts(w, " name=\"");
wrbuf_xmlputs(w, *name ? name : "Unknown");
- wrbuf_puts(w, "\">");
+ wrbuf_puts(w, "\" ");
- write_metadata(w, service, r->metadata, show_details);
- wrbuf_puts(w, "\n");
+ wrbuf_puts(w, "checksum=\"");
+ wrbuf_printf(w, "%u", r->checksum);
+ wrbuf_puts(w, "\">\n");
+
+ write_metadata(w, service, r->metadata, show_details, 2);
+ wrbuf_puts(w, " \n");
}
static void show_raw_record_error(void *data, const char *addinfo)
@@ -858,14 +945,13 @@ static void show_record(struct http_channel *c, struct http_session *s)
{
struct http_response *rs = c->response;
struct http_request *rq = c->request;
- //struct http_session *s = locate_session(c);
struct record_cluster *rec, *prev_r, *next_r;
- struct record *r;
struct conf_service *service;
const char *idstr = http_argbyname(rq, "id");
const char *offsetstr = http_argbyname(rq, "offset");
const char *binarystr = http_argbyname(rq, "binary");
-
+ const char *checksumstr = http_argbyname(rq, "checksum");
+
if (!s)
return;
service = s->psession->service;
@@ -886,38 +972,47 @@ static void show_record(struct http_channel *c, struct http_session *s)
{
error(rs, PAZPAR2_RECORD_MISSING, idstr);
}
- //release_session(c, s);
return;
}
- if (offsetstr)
+ if (offsetstr || checksumstr)
{
- int offset = atoi(offsetstr);
const char *syntax = http_argbyname(rq, "syntax");
const char *esn = http_argbyname(rq, "esn");
int i;
struct record*r = rec->records;
int binary = 0;
const char *nativesyntax = http_argbyname(rq, "nativesyntax");
-
+
if (binarystr && *binarystr != '0')
binary = 1;
- for (i = 0; i < offset && r; r = r->next, i++)
- ;
- if (!r)
+ if (checksumstr)
{
- error(rs, PAZPAR2_RECORD_FAIL, "no record at offset given");
+ long v = atol(checksumstr);
+ for (i = 0; r; r = r->next)
+ if (v == r->checksum)
+ break;
+ if (!r)
+ error(rs, PAZPAR2_RECORD_FAIL, "no record");
}
else
{
+ int offset = atoi(offsetstr);
+ for (i = 0; i < offset && r; r = r->next, i++)
+ ;
+ if (!r)
+ error(rs, PAZPAR2_RECORD_FAIL, "no record at offset given");
+ }
+ if (r)
+ {
http_channel_observer_t obs =
http_add_observer(c, r->client, show_raw_reset);
int ret = client_show_raw_begin(r->client, r->position,
syntax, esn,
obs /* data */,
show_raw_record_error,
- (binary ?
- show_raw_record_ok_binary :
+ (binary ?
+ show_raw_record_ok_binary :
show_raw_record_ok),
(binary ? 1 : 0),
nativesyntax);
@@ -930,31 +1025,31 @@ static void show_record(struct http_channel *c, struct http_session *s)
}
else
{
+ struct record *r;
response_open_no_status(c, "record");
- wrbuf_puts(c->wrbuf, "\n");
+ wrbuf_puts(c->wrbuf, "\n ");
wrbuf_xmlputs(c->wrbuf, rec->recid);
wrbuf_puts(c->wrbuf, "\n");
if (prev_r)
{
- wrbuf_puts(c->wrbuf, "");
+ wrbuf_puts(c->wrbuf, " ");
wrbuf_xmlputs(c->wrbuf, prev_r->recid);
wrbuf_puts(c->wrbuf, "\n");
}
if (next_r)
{
- wrbuf_puts(c->wrbuf, "");
+ wrbuf_puts(c->wrbuf, " ");
wrbuf_xmlputs(c->wrbuf, next_r->recid);
wrbuf_puts(c->wrbuf, "\n");
}
- wrbuf_printf(c->wrbuf, "%d\n",
+ wrbuf_printf(c->wrbuf, " %d\n",
session_active_clients(s->psession));
- write_metadata(c->wrbuf, service, rec->metadata, 1);
+ write_metadata(c->wrbuf, service, rec->metadata, 1, 1);
for (r = rec->records; r; r = r->next)
- write_subrecord(r, c->wrbuf, service, 1);
+ write_subrecord(r, c->wrbuf, service, 2);
response_close(c, "record");
}
show_single_stop(s->psession, rec);
- //release_session(c, s);
}
static void cmd_record_ready(void *data)
@@ -987,12 +1082,15 @@ static void show_records(struct http_channel *c, struct http_session *s, int act
const char *start = http_argbyname(rq, "start");
const char *num = http_argbyname(rq, "num");
const char *sort = http_argbyname(rq, "sort");
+ int version = get_version(rq);
+
int startn = 0;
int numn = 20;
int total;
Odr_int total_hits;
+ Odr_int approx_hits;
int i;
-
+ struct conf_service *service = 0;
if (!s)
return;
@@ -1004,21 +1102,27 @@ static void show_records(struct http_channel *c, struct http_session *s, int act
startn = atoi(start);
if (num)
numn = atoi(num);
- if (!sort)
- sort = "relevance";
- if (!(sp = reclist_parse_sortparms(c->nmem, sort, s->psession->service)))
+
+ service = s->psession->service;
+ if (!sort) {
+ sort = service->default_sort;
+ }
+ if (!(sp = reclist_parse_sortparms(c->nmem, sort, service)))
{
error(rs, PAZPAR2_MALFORMED_PARAMETER_VALUE, "sort");
return;
}
-
- rl = show_range_start(s->psession, sp, startn, &numn, &total, &total_hits);
+
+ rl = show_range_start(s->psession, sp, startn, &numn, &total, &total_hits, &approx_hits);
response_open(c, "show");
wrbuf_printf(c->wrbuf, "\n%d\n", active);
wrbuf_printf(c->wrbuf, "%d\n", total);
wrbuf_printf(c->wrbuf, "" ODR_INT_PRINTF "\n", total_hits);
+ if (version >= 2) {
+ wrbuf_printf(c->wrbuf, "" ODR_INT_PRINTF "\n", approx_hits);
+ }
wrbuf_printf(c->wrbuf, "%d\n", startn);
wrbuf_printf(c->wrbuf, "%d\n", numn);
@@ -1030,15 +1134,23 @@ static void show_records(struct http_channel *c, struct http_session *s, int act
struct conf_service *service = s->psession->service;
wrbuf_puts(c->wrbuf, "\n");
- write_metadata(c->wrbuf, service, rec->metadata, 0);
+ write_metadata(c->wrbuf, service, rec->metadata, 0, 1);
for (ccount = 0, p = rl[i]->records; p; p = p->next, ccount++)
write_subrecord(p, c->wrbuf, service, 0); // subrecs w/o details
- if (ccount > 1)
- wrbuf_printf(c->wrbuf, "%d\n", ccount);
+ wrbuf_printf(c->wrbuf, " %d\n", ccount);
if (strstr(sort, "relevance"))
- wrbuf_printf(c->wrbuf, "%d\n",
+ {
+ wrbuf_printf(c->wrbuf, " %d\n",
rec->relevance_score);
- wrbuf_puts(c->wrbuf, "");
+ if (service->rank_debug)
+ {
+ wrbuf_printf(c->wrbuf, " \n");
+ wrbuf_xmlputs(c->wrbuf, wrbuf_cstr(rec->relevance_explain1));
+ wrbuf_xmlputs(c->wrbuf, wrbuf_cstr(rec->relevance_explain2));
+ wrbuf_printf(c->wrbuf, " \n");
+ }
+ }
+ wrbuf_puts(c->wrbuf, " ");
wrbuf_xmlputs(c->wrbuf, rec->recid);
wrbuf_puts(c->wrbuf, "\n");
wrbuf_puts(c->wrbuf, "\n");
@@ -1060,6 +1172,7 @@ static void show_records_ready(void *data)
else {
/* some error message */
}
+ release_session(c,s);
}
static void cmd_show(struct http_channel *c)
@@ -1069,22 +1182,30 @@ static void cmd_show(struct http_channel *c)
struct http_session *s = locate_session(c);
const char *block = http_argbyname(rq, "block");
const char *sort = http_argbyname(rq, "sort");
+ const char *block_error = http_argbyname(rq, "report");
+ struct conf_service *service = 0;
+
struct reclist_sortparms *sp;
int status;
-
+ int report_error = 0;
+ if (block_error && !strcmp("1", block_error)) {
+ report_error = 1;
+ }
if (!s)
return;
- if (!sort)
- sort = "relevance";
-
- if (!(sp = reclist_parse_sortparms(c->nmem, sort, s->psession->service)))
+ service = s->psession->service;
+ if (!sort) {
+ sort = service->default_sort;
+ }
+
+ if (!(sp = reclist_parse_sortparms(c->nmem, sort, service)))
{
error(c->response, PAZPAR2_MALFORMED_PARAMETER_VALUE, "sort");
release_session(c, s);
return;
}
- session_sort(s->psession, sp->name, sp->increasing);
+ session_sort(s->psession, sp);
status = session_active_clients(s->psession);
@@ -1098,32 +1219,46 @@ static void cmd_show(struct http_channel *c)
{
yaz_log(c->http_sessions->log_level,
"Session %u: Blocking on command show (preferred targets)", s->session_id);
+ release_session(c, s);
+ return;
}
else
{
- yaz_log(YLOG_WARN, "Attempt to block multiple times on show (preferred targets) block. Not supported!");
- error(rs, PAZPAR2_ALREADY_BLOCKED, "show (preferred targets)");
+ yaz_log(YLOG_WARN, "Session %u: Attempt to block multiple times on show (preferred targets) block. Not supported!",
+ s->session_id);
+ if (report_error) {
+ error(rs, PAZPAR2_ALREADY_BLOCKED, "show (preferred targets)");
+ release_session(c, s);
+ return;
+ }
+ else {
+ yaz_log(YLOG_WARN, "Session %u: Ignoring show(preferred) block. Returning current result.", s->session_id);
+ }
}
- release_session(c, s);
- return;
}
else if (status)
{
// if there is already a watch/block. we do not block this one
if (session_set_watch(s->psession, SESSION_WATCH_SHOW,
- show_records_ready, c, c) != 0
- )
+ show_records_ready, c, c) != 0)
{
- yaz_log(YLOG_WARN, "Attempt to block multiple times on show block. Not supported!");
- error(rs, PAZPAR2_ALREADY_BLOCKED, "show");
+ yaz_log(YLOG_WARN, "Session %u: Attempt to block multiple times on show block. Not supported!", s->session_id);
+ if (report_error) {
+ error(rs, PAZPAR2_ALREADY_BLOCKED, "show");
+ release_session(c, s);
+ return;
+ }
+ else {
+ yaz_log(YLOG_WARN, "Session %u: Ignoring show block. Returning current result.", s->session_id);
+ }
}
else
{
yaz_log(c->http_sessions->log_level, "Session %u: Blocking on command show", s->session_id);
+ release_session(c, s);
+ return;
}
- release_session(c, s);
- return;
}
}
show_records(c, s, status);
@@ -1150,11 +1285,15 @@ static void cmd_search(struct http_channel *c)
const char *maxrecs = http_argbyname(rq, "maxrecs");
const char *startrecs = http_argbyname(rq, "startrecs");
const char *limit = http_argbyname(rq, "limit");
+ const char *sort = http_argbyname(rq, "sort");
enum pazpar2_error_code code;
const char *addinfo = 0;
+ struct reclist_sortparms *sp;
+ struct conf_service *service = 0;
if (!s)
return;
+
if (!query)
{
error(rs, PAZPAR2_MISSING_PARAMETER, "query");
@@ -1167,8 +1306,19 @@ static void cmd_search(struct http_channel *c)
release_session(c, s);
return;
}
+ service = s->psession->service;
+ if (!sort) {
+ sort = service->default_sort;
+ }
+ if (!(sp = reclist_parse_sortparms(c->nmem, sort, s->psession->service)))
+ {
+ error(c->response, PAZPAR2_MALFORMED_PARAMETER_VALUE, "sort");
+ release_session(c, s);
+ return;
+ }
+
code = session_search(s->psession, query, startrecs, maxrecs, filter, limit,
- &addinfo, "relevance", 0);
+ &addinfo, sp);
if (code)
{
error(rs, code, addinfo);
@@ -1238,7 +1388,7 @@ static void cmd_info(struct http_channel *c)
wrbuf_puts(c->wrbuf, "\n");
wrbuf_puts(c->wrbuf, " \n");
-
+
info_services(c->server, c->wrbuf);
response_close(c, "info");