Bugfixes for decomiling underspecified terms

[cql-java-moved-to-github.git] / src / org / z3950 / zing / cql / CQLTermNode.java

diff --git a/src/org/z3950/zing/cql/CQLTermNode.java b/src/org/z3950/zing/cql/CQLTermNode.java
index 399ce10..a519215 100644 (file)
--- a/src/org/z3950/zing/cql/CQLTermNode.java
+++ b/src/org/z3950/zing/cql/CQLTermNode.java
@@ -1,4 +1,4 @@
-// $Id: CQLTermNode.java,v 1.18 2002-12-12 10:24:25 mike Exp $
+// $Id: CQLTermNode.java,v 1.22 2006-06-14 14:36:36 mike Exp $
 
 package org.z3950.zing.cql;
 import java.util.Properties;
@@ -12,7 +12,7 @@ import java.util.Vector;
  * these must be provided - you can't have a qualifier without a
  * relation or vice versa.
  *
- * @version    $Id: CQLTermNode.java,v 1.18 2002-12-12 10:24:25 mike Exp $
+ * @version    $Id: CQLTermNode.java,v 1.22 2006-06-14 14:36:36 mike Exp $
  */
 public class CQLTermNode extends CQLNode {
     private String qualifier;
@@ -34,8 +34,14 @@ public class CQLTermNode extends CQLNode {
     public CQLRelation getRelation() { return relation; }
     public String getTerm() { return term; }
 
+    private static boolean isResultSetQualifier(String qual) {
+       return (qual.equals("srw.resultSet") ||
+               qual.equals("srw.resultSetId") ||
+               qual.equals("srw.resultSetName"));
+    }
+
     public String getResultSetName() {
-       if (qualifier.equals("srw.resultSet"))
+       if (isResultSetQualifier(qualifier))
            return term;
        else
            return null;
@@ -55,7 +61,8 @@ public class CQLTermNode extends CQLNode {
        String quotedTerm = maybeQuote(term);
        String res = quotedTerm;
 
-       if (!qualifier.equalsIgnoreCase("srw.serverChoice")) {
+       if (qualifier != null &&
+           !qualifier.equalsIgnoreCase("srw.serverChoice")) {
            // ### We don't always need spaces around `relation'.
            res = quotedQualifier + " " + relation.toCQL() + " " + quotedTerm;
        }
@@ -141,7 +148,7 @@ public class CQLTermNode extends CQLNode {
     }
 
     public String toPQF(Properties config) throws PQFTranslationException {
-       if (qualifier.equals("srw.resultSet")) {
+       if (isResultSetQualifier(qualifier)) {
            // Special case: ignore relation, modifiers, wildcards, etc.
            // There's parallel code in toType1BER()
            return "@set " + maybeQuote(term);
@@ -166,6 +173,9 @@ public class CQLTermNode extends CQLNode {
     }
 
     static String maybeQuote(String str) {
+       if (str == null)
+          return null;
+
        // There _must_ be a better way to make this test ...
        if (str.length() == 0 ||
            str.indexOf('"') != -1 ||
@@ -184,7 +194,7 @@ public class CQLTermNode extends CQLNode {
     }
 
     public byte[] toType1BER(Properties config) throws PQFTranslationException {
-       if (qualifier.equals("srw.resultSet")) {
+       if (isResultSetQualifier(qualifier)) {
            // Special case: ignore relation, modifiers, wildcards, etc.
            // There's parallel code in toPQF()
            byte[] operand = new byte[term.length()+100];
@@ -210,8 +220,7 @@ public class CQLTermNode extends CQLNode {
        if (len > 0 && text.substring(len-1, len).equals("^"))
            text = text.substring(0, len-1);
 
-       String attr, attrList, term = maybeQuote(text);
-       System.out.println("in CQLTermNode.toType1BER(): PQF=" + toPQF(config));
+       String attr, attrList, term = text;
        byte[] operand = new byte[text.length()+100];
        int i, j, offset, type, value;
        offset = putTag(CONTEXT, 0, CONSTRUCTED, operand, 0); // op
@@ -220,8 +229,6 @@ public class CQLTermNode extends CQLNode {
        operand[offset++] = (byte)(0x80&0xff); // indefinite length
        offset = putTag(CONTEXT, 44, CONSTRUCTED, operand, offset); // AttributeList
        operand[offset++] = (byte)(0x80&0xff); // indefinite length
-       offset = putTag(UNIVERSAL, SEQUENCE, CONSTRUCTED, operand, offset);
-       operand[offset++] = (byte)(0x80&0xff);
 
        Vector attrs = getAttrs(config);
        for(i = 0; i < attrs.size(); i++) {
@@ -231,6 +238,8 @@ public class CQLTermNode extends CQLNode {
            while (st.hasMoreTokens()) {
                attr = st.nextToken();
                j = attr.indexOf('=');
+               offset = putTag(UNIVERSAL, SEQUENCE, CONSTRUCTED, operand, offset);
+               operand[offset++] = (byte)(0x80&0xff);
                offset = putTag(CONTEXT, 120, PRIMITIVE, operand, offset);
                type = Integer.parseInt(attr.substring(0, j));
                offset = putLen(numLen(type), operand, offset);
@@ -240,10 +249,10 @@ public class CQLTermNode extends CQLNode {
                value = Integer.parseInt(attr.substring(j+1));
                offset = putLen(numLen(value), operand, offset);
                offset = putNum(value, operand, offset);
+               operand[offset++] = 0x00; // end of SEQUENCE
+               operand[offset++] = 0x00;
            }
        }
-       operand[offset++] = 0x00; // end of SEQUENCE
-       operand[offset++] = 0x00;
        operand[offset++] = 0x00; // end of AttributeList
        operand[offset++] = 0x00;