From a59ee0ce86aebff91e46adc1310f0a7699d88845 Mon Sep 17 00:00:00 2001 From: Jakub Skoczen Date: Fri, 8 Mar 2013 13:17:58 +0100 Subject: [PATCH] Fix text/cdata nodes collection --- .gitattributes | 1 + js/pz2.js | 26 +++++++++++++++++--------- 2 files changed, 18 insertions(+), 9 deletions(-) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000..13f250a --- /dev/null +++ b/.gitattributes @@ -0,0 +1 @@ +js/pz2.js ident diff --git a/js/pz2.js b/js/pz2.js index 4ff5798..4f16ccb 100644 --- a/js/pz2.js +++ b/js/pz2.js @@ -1,5 +1,5 @@ /* - * Mine + * $Id$ ** pz2.js - pazpar2's javascript client library. */ @@ -1065,35 +1065,43 @@ Element_parseChildNodes = function (node) { var parsed = {}; var hasChildElems = false; + var textContent = ''; if (node.hasChildNodes()) { var children = node.childNodes; for (var i = 0; i < children.length; i++) { var child = children[i]; - if (child.nodeType == Node.ELEMENT_NODE) { + switch (child.nodeType) { + case Node.ELEMENT_NODE: hasChildElems = true; var nodeName = child.nodeName; if (!(nodeName in parsed)) parsed[nodeName] = []; parsed[nodeName].push(Element_parseChildNodes(child)); + break; + case Node.TEXT_NODE: + textContent += child.nodeValue; + break; + case Node.CDATA_SECTION_NODE: + textContent += child.nodeValue; + break; } } } var attrs = node.attributes; for (var i = 0; i < attrs.length; i++) { + hasChildElems = true; var attrName = '@' + attrs[i].nodeName; var attrValue = attrs[i].nodeValue; parsed[attrName] = attrValue; } - // if no nested elements, get text content - if (node.hasChildNodes() && !hasChildElems) { - if (node.attributes.length) - parsed['#text'] = node.firstChild.nodeValue; - else - parsed = node.firstChild.nodeValue; - } + // if no nested elements/attrs set value to text + if (hasChildElems) + parsed['#text'] = textContent; + else + parsed = textContent; return parsed; } -- 1.7.10.4